[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling
Re: [PATCH v2 1/2] posix: Add compat glob symbol to not follow dangling symbols
Fri, 22 Sep 2017 14:43:43 -0700
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0
On 09/22/2017 06:02 AM, Adhemerval Zanella wrote:
+ ((flags & (GLOB_ERR | GLOB_NOESCAPE | GLOB_ALTDIRFUNC))
+ | GLOB_NOSORT | GLOB_ONLYDIR),
The indenting is not quite right here: the "|" should be under the 2nd
"(" in the previous line, not under the 1st.
+ result = __glob (onealt,
+ ((flags & ~(GLOB_NOCHECK | GLOB_NOMAGIC))
+ | GLOB_APPEND), errfunc, pglob);
As long as we're changing indenting anyway, we should fix the indenting
here to match the usual GNU style. Something like this:
result = __glob (onealt,
((flags & ~(GLOB_NOCHECK | GLOB_NOMAGIC))
Other than these minor indenting things it looks OK. glibc's glob.c is
wrongly indented elsewhere, but that can be fixed separately.
Proposed corresponding gnulib patch attached; it would keep gnulib
glob.c in sync with glibc's, except for whitespace and the https: thing.
CC'ing this to bug-gnulib.
Description: Text Data