[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug #33724] Find command is changing the access time of directory
From: |
Bernhard Voelker |
Subject: |
Re: [bug #33724] Find command is changing the access time of directory |
Date: |
Sat, 29 Sep 2018 21:54:06 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/29/18 9:30 AM, James Youngman wrote:
> Having a "don't update atime" option that only works sometimes (when I
> own the directory) seems problematic to me.
>
> If the user specifies the "keep access time unchanged" option and we
> can't honour it (because there is at least one directory that they
> don't own) what should we do?
>
> We can't simply abort at the time the error is detected, since we have
> searched some of the file system, and possibly generated some side
> effects. But perhaps the user would not want us to continue
> either. Reserving the option doesn't seem especially helpful, either
> (and may not work over NFS or other remote filesystems where root is
> squashed).
>
> In short, I can't see a way of making such an option non-user-surprising.
So regarding gnulib, there are 2 alternatives:
a) rename FTS_NOATIME to FTS_NOATIME, and add a retry to open/openat
in each place when that was using O_NOATIME and we got EPERM.
b) remove FTS_NOATIME - the attached would do that ... in the naive
hope that no other project has picked it up yet (which I doubt).
I'm 60:40 pro b).
Comments?
Have a nice day,
Berny
0001-fts-remove-FTS_NOATIME.patch
Description: Text Data