[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: __builtin_expect used in regex

From: arnold
Subject: Re: __builtin_expect used in regex
Date: Mon, 01 Oct 2018 12:31:34 -0600
User-agent: Heirloom mailx 12.4 7/29/08

Hi Paul,

Paul Eggert <address@hidden> wrote:

> Thanks for reporting the problem. Please try the attached patch against
> Gawk master. The ChangeLog entry is a bit optimistic, as it is assuming
> that the patch works (and if it works, I would like to install the
> relevant changes into Gnulib and into glibc, so that at that point the
> ChangeLog entry will be correct).

Those changes look really excessive to me.  I prefer to not have to
keep including more and more files from gnulib just to compile regex
or dfa.

(As a side point, does all the __builtin_expect / __glibc_unlikely
stuff *really* make that much difference?  It sure clutters up
the code unmercifully.)

> Alternatively, if you want a smaller patch you can arrange for
> __builtin_expect to be a no-op on compilers that do not support it,
> as Bruno suggested.

That is what I will do, either in my custom.h or directly in



reply via email to

[Prev in Thread] Current Thread [Next in Thread]