Re: [PATCH v4] Ensure mktime sets errno on error (bug 23789)

[Albert ARIBAUD]

Hi Paul,

On Sun, 4 Nov 2018 23:54:59 -0800, Paul Eggert <address@hidden>
wrote :

> Paul Eggert wrote:
> > 3. Please construct a third patch containing your mktime test case for 
> > glibc, 
> > and we then apply that patch to glibc.  
> 
> I looked at that test case and found some issues with it, e.g., it assumed a 
> particular time_t width in some cases and assumed a particular error number 
> in 
> others. Attached is a revised test case that should fix the issues. For 
> convenience I'm also attaching the same glibc code patch again.

Apparently, with both your patches applied there are still paths which
yield "mktime failed without setting errno" when make check is run for
i686-linux-gnu. I'll go through the call path and see where it fails. 

Cordialement,
Albert ARIBAUD
3ADEV