bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mkdir-p: Don't discard stat error


From: Paul Eggert
Subject: Re: [PATCH] mkdir-p: Don't discard stat error
Date: Fri, 14 Dec 2018 16:27:30 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/14/18 1:10 PM, Niklas Hambüchen wrote:
+                  if (stat (dir + prefix_len, &st) == 0
+                      && S_ISDIR (st.st_mode))
+                    return true;
+                  else
+                    {
+                      error (0, errno,
+                             _("cannot stat %s"),
+                             quote (dir + prefix_len));
+                      return false;
+                    }

Thanks for the bug report. That patch doesn't look quite right, since it can use errno even when stat succeeded (in which case errno contains garbage). I installed the attached instead; please give it a try.

Attachment: 0001-mkdir-p-improve-diagnostic-for-FUSE-mounts.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]