[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 0/2] Fix syntax-check on macOS/FreeBSD

From: Eric Blake
Subject: Re: [PATCH v3 0/2] Fix syntax-check on macOS/FreeBSD
Date: Wed, 2 Jan 2019 14:14:32 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/20/18 7:06 AM, Roman Bolshakov wrote:
> On Thu, Dec 13, 2018 at 06:34:51PM +0300, Roman Bolshakov wrote:
>> Hello,
>> There was an issue with syntax-check on FreeBSD reported a few years
>> ago:
>> https://www.redhat.com/archives/libvir-list/2015-August/msg00758.html
>> http://lists.gnu.org/archive/html/bug-gnulib/2015-08/msg00019.html
>> The patch series attempts to resolve the issue on gnulib side. With
>> related changes on libvirt side I can run make syntax-check on macOS.
> Hi Bruno and Eric,
> what do you think of the patchset?

Your change is larger than 10 lines, but is mechanical enough that I
felt that it qualified under the tiny change rules without you having
copyright assignment on file.  But if you want to make further gnulib
contributions, completing the copyright assignment is probably worth doing.

Sorry for the holiday delay. I've now applied the patches, with tweaks
as discussed on 1/2.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]