bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: undefined behaviour findings in bitset


From: Akim Demaille
Subject: Re: undefined behaviour findings in bitset
Date: Tue, 19 Mar 2019 07:07:08 +0100

Hi Bruno,

> Le 18 mars 2019 à 22:03, Bruno Haible <address@hidden> a écrit :
> 
> Hi Akim,
> 
>> Also, the relationship with noreturn.h is not completely clear for
>> me either.
> 
> There are a couple of comment in noreturn.h lines 33..41. But I agree,
> some text in the documentation would be better.
> 
>> Clang 7 pretends to be GCC 4.2 (__GNUC__ __GNUC_MINOR__).
> 
>> For instance I see it already has the above fix for
>> GCC 4.7, but in a different way.
>> 
>> /* Use ISO C++11 syntax when the compiler supports it. */
>> # if (__cplusplus >= 201103 && !(__GNUC__ == 4 && __GNUC_MINOR__ == 7)) \
>>  || (_MSC_VER >= 1900)
>> # define _GL_NORETURN_FUNC [[noreturn]]
> 
> Right, this snippet gets clang++ and MSVC++ support right. How about this
> patch?

Yes, I agree this is the best option so far, thanks!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]