Re: [PATCH 0/1] Reduce footprint of xstrtol module

[Pino Toscano]

Hi Bruno,

On Thursday, 5 December 2019 22:56:08 CET Bruno Haible wrote:
> One suggestion, though:
> 
> >  lib/xstrtol-error.h   | 45 +++++++++++++++++++++++++++++++++++++++++++
> >  lib/xstrtol.h         | 20 -------------------
> 
> It is possible to have several modules share the same .h file. For example,
> <math.h> is used by many modules. If you leave xstrtol.h as is, users of the
> module don't need to change their source code, they only need to import the
> new module 'xstrtol-error'.
> A separate .h file, on the other hand, provides a more orthogonal code
> structure.

Yes, this was a conscious decision, because of the <getopt.h> include
in xstrtol.h: since the goal was to not require it for users of
xstrto*, as it is not required for who does not use xstrtol_fatal().
If I leave xstrtol.h as it was, then I still need to keep getopt-gnu
as required dependency for xstrtol.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.