bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

add dependencies to 'fstat'


From: Bruno Haible
Subject: add dependencies to 'fstat'
Date: Mon, 09 Mar 2020 00:56:37 +0100
User-agent: KMail/5.1.3 (Linux/4.4.0-174-generic; KDE/5.18.0; x86_64; ; )

We have documented on 2020-01-03 that fstat() needs workarounds even on plain
glibc/Linux systems. So, basically every use of fstat() in gnulib needs a
dependency on the 'fstat' module. I found these:

af_alg.c:117:  if (0 <= off && fstat (fd, &st) == 0
at-func2.c:128:      if (stat (".", &st1) == -1 || fstat (fd2, &st2) == -1)
at-func2.c:140:      if (stat (".", &st2) == -1 || fstat (fd1, &st1) == -1)
at-func2.c:152:      if (fstat (fd1, &st1) == -1 || fstat (fd2, &st2) == -1)
same.c:113:      if (destdir_fd < 0 || fstat (destdir_fd, &dest_dir_stats) != 0)
term-style-control.c:971:              && fstat (STDERR_FILENO, &statbuf2) >= 0


2020-03-08  Bruno Haible  <address@hidden>

        crypto/af_alg, renameatu, same, term-style-control: Depend on fstat.
        * modules/crypto/af_alg (Depends-on): Add fstat.
        * modules/renameatu (Depends-on): Likewise.
        * modules/same (Depends-on): Likewise.
        * modules/term-style-control (Depends-on): Likewise.

diff --git a/modules/crypto/af_alg b/modules/crypto/af_alg
index 95273d4..ec263b0 100644
--- a/modules/crypto/af_alg
+++ b/modules/crypto/af_alg
@@ -12,6 +12,7 @@ c99             [test $USE_AF_ALG = 1]
 fflush          [test $USE_AF_ALG = 1]
 fseeko          [test $USE_AF_ALG = 1]
 ftello          [test $USE_AF_ALG = 1]
+fstat           [test $USE_AF_ALG = 1]
 sys_socket
 sys_stat
 
diff --git a/modules/renameatu b/modules/renameatu
index 1c3fd99..bc320d1 100644
--- a/modules/renameatu
+++ b/modules/renameatu
@@ -17,6 +17,7 @@ statat           [test $REPLACE_RENAMEAT = 1]
 stdbool          [test $REPLACE_RENAMEAT = 1]
 at-internal      [test $HAVE_RENAMEAT = 0]
 dosname          [test $HAVE_RENAMEAT = 0]
+fstat            [test $HAVE_RENAMEAT = 0]
 getcwd-lgpl      [test $HAVE_RENAMEAT = 0]
 openat-die       [test $HAVE_RENAMEAT = 0]
 rename           [test $HAVE_RENAMEAT = 0]
diff --git a/modules/same b/modules/same
index 889ccbd..24c9cf3 100644
--- a/modules/same
+++ b/modules/same
@@ -10,6 +10,7 @@ m4/same.m4
 Depends-on:
 error
 dirname
+fstat
 fstatat
 openat
 same-inode
diff --git a/modules/term-style-control b/modules/term-style-control
index fb2d098..0a2f935 100644
--- a/modules/term-style-control
+++ b/modules/term-style-control
@@ -11,6 +11,7 @@ fatal-signal
 sigaction
 sigprocmask
 full-write
+fstat
 same-inode
 
 configure.ac:




reply via email to

[Prev in Thread] Current Thread [Next in Thread]