[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] Use SecureZeroMemory on windows for explicit_bzero

From: Bruno Haible
Subject: Re: [PATCH 2/5] Use SecureZeroMemory on windows for explicit_bzero
Date: Sun, 12 Apr 2020 00:23:39 +0200
User-agent: KMail/5.1.3 (Linux/4.4.0-174-generic; KDE/5.18.0; x86_64; ; )

Hello Bastien,

Same comments about preprocessor directive indentation,
GNU style, and the autoconf/shell variables.

> diff --git a/lib/explicit_bzero.c b/lib/explicit_bzero.c
> index 862855421..b355f9bdf 100644
> --- a/lib/explicit_bzero.c
> +++ b/lib/explicit_bzero.c
> @@ -32,6 +32,11 @@
>  #include <string.h>
> +#if defined WIN32 && defined HAVE_SECUREZEROMEMORY

The preprocessor condition for the Windows API is not
  defined WIN32
  defined _WIN32 && !defined __CYGWIN__

Also, since this function is present on Windows XP and newer

and gnulib does not target older versions of Windows, you can
probably just omit the HAVE_SECUREZEROMEMORY test.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]