[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] read-file: add variants that clear internal memory
|
From: |
Bruno Haible |
|
Subject: |
Re: [PATCH] read-file: add variants that clear internal memory |
|
Date: |
Wed, 27 May 2020 13:12:51 +0200 |
|
User-agent: |
KMail/5.1.3 (Linux/4.4.0-177-generic; KDE/5.18.0; x86_64; ; ) |
Hi Daiki,
> Here are the two separate commits for this.
The first one is nearly perfect. Only the NEWS entry should go into section
"User visible incompatible changes", not into section "Important general notes".
The second one:
- In fread_file, around line 100, you use a realloc workaround that appears
to be not as reliable as the malloc+free based workaround around line 135.
- In read_file, please don't use tabs for indentation. We've switched to
spaces-only indentation long ago.
Once this is fixed, please push.
Bruno
- [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/26
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/27
- Re: [PATCH] read-file: add variants that clear internal memory,
Bruno Haible <=
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/27
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/28
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/28
- Re: [PATCH] read-file: add variants that clear internal memory, Bruno Haible, 2020/05/29
- Re: [PATCH] read-file: add variants that clear internal memory, Daiki Ueno, 2020/05/29