Re: autoconf-2.69c released [beta]

[Bruno Haible]

Gavin Smith wrote:
> %
> 
> AC_HELP_STRING from threadlib.m4.  Also used in libgcrypt.m4.  Running 
> autoupdate on those files and editing the result gives the patch I've 
> attached.
> 
> %
> 
> $as_echo_n is used in gnulib-common.m4 around a call to AC_CACHE_VAL:
> 
> # gl_CACHE_VAL_SILENT(cache-id, command-to-set-it)
> # is like AC_CACHE_VAL(cache-id, command-to-set-it), except that it does not
> # output a spurious "(cached)" mark in the midst of other configure output.
> # This macro should be used instead of AC_CACHE_VAL when it is not surrounded
> # by an AC_MSG_CHECKING/AC_MSG_RESULT pair.
> AC_DEFUN([gl_CACHE_VAL_SILENT],
> [
>   saved_as_echo_n="$as_echo_n"
>   as_echo_n=':'
>   AC_CACHE_VAL([$1], [$2])
>   as_echo_n="$saved_as_echo_n"
> ])
> 
> AC_CACHE_VAL calls _AS_ECHO_N which is defined in m4sh.sh from autoconf.  
> The as_echo_n shell variable is not referred to at all, so this 
> redefinition appears to be ineffectual.  gl_CACHE_VAL_SILENT is not used 
> from gnulib-common.m4 itself but is used from a handful of other 
> modules.  It is used in the stdarg module, but the issue of spurious 
> output only arises if the "va_copy" function was not found.
> The other files using gl_CACHE_VAL_SILENT were
> 
> floorf.m4, floorl.m4, floor.m4, ceilf.m4, ceilr.m4, ceil.m4
> 
> but I haven't tested whether these can produce spurious output.
> 

I'm committing these patches, for these two problems.


2020-09-27  Gavin Smith  <gavinsmith0123@gmail.com>

        Avoid "warning: The macro `AC_HELP_STRING' is obsolete".
        * m4/threadlib.m4 (gl_THREADLIB_EARLY_BODY): Use AS_HELP_STRING instead
        of AC_HELP_STRING.
        * m4/libgcrypt.m4 (AM_PATH_LIBGCRYPT): Likewise.

2020-09-27  Bruno Haible  <bruno@clisp.org>

        Avoid "warning: $as_echo_n is obsolete" from autoconf 2.69c.
        Reported by Gavin Smith <gavinsmith0123@gmail.com> in
        <https://lists.gnu.org/archive/html/bug-gnulib/2020-09/msg00151.html>.
        * m4/gnulib-common.m4 (gl_CACHE_VAL_SILENT): Use gl_SILENT.

0001-Avoid-warning-as_echo_n-is-obsolete-from-autoconf-2..patch
Description: Text Data

0002-Avoid-warning-The-macro-AC_HELP_STRING-is-obsolete.patch
Description: Text Data