[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/6] canonicalize: fix EOVERFLOW bug
From: |
Bruno Haible |
Subject: |
Re: [PATCH 2/6] canonicalize: fix EOVERFLOW bug |
Date: |
Fri, 11 Dec 2020 12:47:42 +0100 |
User-agent: |
KMail/5.1.3 (Linux/4.4.0-193-generic; KDE/5.18.0; x86_64; ; ) |
Hi Paul,
> 2020-12-02 Paul Eggert <eggert@cs.ucla.edu>
>
> + canonicalize: fix EOVERFLOW bug
> + * lib/canonicalize.c (canonicalize_filename_mode):
> + When testing whether a directory entry is a symbolic link, or a
> + directory or other, do not use lstat or stat or
> + areadlink_with_size. Just use areadlink, as this suffices and it
> + avoids the EOVERFLOW problem that lstat and stat have.
> + * modules/canonicalize (Depends-on): Depend on areadlink instead
> + of areadlink-with-size and stat.
This patch introduced a unit test regression on AIX 7.2.
Reproducible on gcc119.fsffrance.org both in 32-bit and 64-bit mode
through
$ git checkout 47f74ead5c1cb72d489ea06a8a716eb0f65a430c
$ rm -rf ../testdir-canon4; ./gnulib-tool --create-testdir
--dir=../testdir-canon4 --single-configure canonicalize
and running testdir-canon4 on this machine.
Details:
../../gltests/test-canonicalize.c:112: assertion 'result1 == NULL' failed
FAIL test-canonicalize (exit status: 134)
Bruno
[PATCH 6/6] canonicalize: refactor can_mode flag, Paul Eggert, 2020/12/02
[PATCH 5/6] canonicalize: prefer signed integer types, Paul Eggert, 2020/12/02
Re: [PATCH 1/6] canonicalize-lgpl: fix EOVERFLOW bug, Adhemerval Zanella, 2020/12/11