[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: support shallow gnulib submodule checkouts

From: Simon Josefsson
Subject: Re: support shallow gnulib submodule checkouts
Date: Tue, 16 Aug 2022 15:51:34 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Updated patch below.

Meanwhile, I'll disable the public-submodule-commit test in the projects
I work on -- I don't think it is appropriate to run it on every 'make
check' invocation.  Disable it by putting this in cfg.mk:

submodule-checks =
gl_public_submodule_commit =


diff --git a/top/maint.mk b/top/maint.mk
index c1fdf9ca2c..1982833e91 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1493,10 +1493,13 @@ submodule-checks ?= no-submodule-changes 
 # Ensure that each sub-module commit we're using is public.
 # Without this, it is too easy to tag and release code that
 # cannot be built from a fresh clone.
+gl_seed ?= d146c864e8d8cc82e96d722337253dd5a3a803b8
 .PHONY: public-submodule-commit
        $(AM_V_GEN)if test -d $(srcdir)/.git                            \
-               && git --version >/dev/null 2>&1; then                  \
+               && git --version >/dev/null 2>&1                        \
+               && { cd $(gnulib_dir) &&                                \
+                       git cat-file -e $(gl_seed); }; then             \
          cd $(srcdir) &&                                               \
          git submodule --quiet foreach                                 \
              'test "$$(git rev-parse "$$sha1")"                        \

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]