[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Use xattr (Linux) in qcopy-acl.c

From: Paul Eggert
Subject: Re: [PATCH] Use xattr (Linux) in qcopy-acl.c
Date: Wed, 4 Jan 2023 11:29:53 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 2023-01-04 06:46, Bruno Haible wrote:
To me, it looks good. Paul's opinion?
I see a problem in linking. With this change, programs using the qcopy-acl module will link to both $(LIB_ACL) and $(LIB_XATTR), even though they do not need to link with $(LIB_ACL). Perhaps you can fix this by fixing the Link sections of the relevant modules to use $(LIB_HAS_ACL) instead of $(LIB_ACL). That is, for each module where you added $(LIB_XATTR), replace its $(LIB_ACL) with $(LIB_HAS_ACL) if the only reason it needed $(LIB_ACL) was to copy attributes.

Also, come to think of it, is there a security issue between the chmod_or_fchmod call, and the attr_copy_fd call? That is, could the file temporarily be set to too-generous permissions, between the two calls? A comment explaining this issue would help.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]