bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

spawn-pipe tests: Fix test failure on Android


From: Bruno Haible
Subject: spawn-pipe tests: Fix test failure on Android
Date: Wed, 11 Jan 2023 21:39:55 +0100

On Android 11, I'm seeing this test failure:

FAIL: test-spawn-pipe.sh
========================

../../gltests/test-spawn-pipe-child.c:134: assertion '! is_open 
(STDERR_FILENO)' failed
test-spawn-pipe.sh: iteration 4 failed
../../gltests/test-spawn-pipe-child.c:134: assertion '! is_open 
(STDERR_FILENO)' failed
test-spawn-pipe.sh: iteration 5 failed
../../gltests/test-spawn-pipe-child.c:134: assertion '! is_open 
(STDERR_FILENO)' failed
test-spawn-pipe.sh: iteration 6 failed
../../gltests/test-spawn-pipe-child.c:134: assertion '! is_open 
(STDERR_FILENO)' failed
test-spawn-pipe.sh: iteration 7 failed
FAIL test-spawn-pipe.sh (exit status: 1)

This patch fixes it.


2023-01-11  Bruno Haible  <bruno@clisp.org>

        spawn-pipe tests: Fix test failure on Android.
        * tests/test-spawn-pipe-child.c (main): Skip the is_open (STDERR_FILENO)
        check on Android.

diff --git a/tests/test-spawn-pipe-child.c b/tests/test-spawn-pipe-child.c
index 071beb320f..1d8a27ffd4 100644
--- a/tests/test-spawn-pipe-child.c
+++ b/tests/test-spawn-pipe-child.c
@@ -127,9 +127,9 @@ main (int argc, char *argv[])
     case 1:
       /* Expect fd 2 is closed.
          But on HP-UX 11, fd 2 gets automatically re-opened to /dev/null if it
-         was closed.  Similarly on native Windows.  Future POSIX will allow
-         this, see <http://austingroupbugs.net/view.php?id=173>.  */
-#if !(defined __hpux || (defined _WIN32 && ! defined __CYGWIN__))
+         was closed.  Similarly on Android and on native Windows.  Future POSIX
+         will allow this, see <http://austingroupbugs.net/view.php?id=173>.  */
+#if !(defined __hpux || defined __ANDROID__ || (defined _WIN32 && ! defined 
__CYGWIN__))
       if (!is_qemu)
         ASSERT (! is_open (STDERR_FILENO));
 #endif






reply via email to

[Prev in Thread] Current Thread [Next in Thread]