[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] better explain functions [q]set-acl.c

From: Bruno Haible
Subject: Re: [PATCH] better explain functions [q]set-acl.c
Date: Mon, 16 Jan 2023 18:19:17 +0100

Hi Ondrej,

> Improve comments for both functions
> ---
>  lib/qset-acl.c | 16 +++++++++-------
>  lib/set-acl.c  | 13 +++++++------
>  2 files changed, 16 insertions(+), 13 deletions(-)

I wanted to apply this patch in your name, but it fails:
error: corrupt patch at line 31

Evidently the patch is not right, because its first hunk has 4 unmodified
lines at the end, instead of 3.

1. make sure that the patch does not add trailing whitespace ("git diff"
   shows red spaces when this happens),
2. regenerate the patch using 'git format-patch', so that each hunk has 3
   unmodified lines at the beginning and at the end,
3. send the patch as an attachment. Your mailer apparently modifies URLs
   in text that you send; we don't need this.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]