bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improve comments for [q]set-acl.c


From: Bruno Haible
Subject: Re: [PATCH] Improve comments for [q]set-acl.c
Date: Tue, 17 Jan 2023 15:27:28 +0100

Hi Ondrej,

> Hi Bruno, sorry, this patch should be fine now.

The patch applies, but it still introduces trailing spaces:
When I apply it I get

Applying: Improve comments for [q]set-acl.c
.git/rebase-apply/patch:23: trailing whitespace.
   ACLs. If DESC is a valid file descriptor, use file descriptor operations 
.git/rebase-apply/patch:24: trailing whitespace.
   where available, else use filename based operations on NAME.  If access 
.git/rebase-apply/patch:25: trailing whitespace.
   control lists are not available, fchmod the target file to MODE.  Also 
.git/rebase-apply/patch:26: trailing whitespace.
   sets the non-permission bits of the destination file 
.git/rebase-apply/patch:50: trailing whitespace.
   ACLs. If DESC is a valid file descriptor, use file descriptor operations 
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.

and when I then do "git diff HEAD~1 HEAD", I see the red markers.

Can you please deal with that before you send the patch? Thanks.

PNG image


reply via email to

[Prev in Thread] Current Thread [Next in Thread]