Re: [PATCH] test-framework-sh: fix spelling typo

[Bruno Haible]

> Paul Eggert wrote:
> > -  saved_IFS="$IFS"; IFS="$PATH_SEPARATOR"
> > +  save_IFS="$IFS"; IFS="$PATH_SEPARATOR"

Thanks, Paul, for fixing this copy&paste mistake. I didn't realize that
I had made a mistake. My brain seems to have an axiom "my commits are
correct" :-(

> I propose to rename:
>   save_IFS -> saved_IFS
>   save_errno -> saved_errno
>   save_alloc -> saved_alloc

Still, this naming of variables issue with <verb>_<noun> bothers me that much
that I'm applying this patch:


2024-01-17  Bruno Haible  <bruno@clisp.org>

        Improve naming of local variables.
        * gnulib-tool, posix-modules, build-aux/relocatable.sh.in,
        build-aux/reloc-ldflags, build-aux/install-reloc, tests/init.sh,
        m4/argz.m4: Rename save_IFS to saved_IFS.
        * m4/*.m4: Rename save_LIBS to saved_LIBS.
        * m4/00gnulib.m4, m4/gnulib-common.m4, m4/warn-on-use.m4, m4/wchar_h.m4:
        Rename save_ac_compile to saved_ac_compile.
        * m4/00gnulib.m4: Rename ac_save_ac_compile to ac_saved_ac_compile.
        * m4/gnulib-common.m4: Rename save_ac_compile_for_check_decl to
        saved_ac_compile_for_check_decl.
        * m4/assert_h.m4, m4/manywarnings.m4, m4/stdalign.m4, m4/visibility.m4:
        Rename gl_save_CFLAGS to gl_saved_CFLAGS.
        * m4/dirfd.m4: Rename dirfd_save_CFLAGS to gl_saved_CFLAGS.
        * m4/include_next.m4, m4/pread.m4, m4/pwrite.m4, m4/termcap.m4,
        m4/terminfo.m4: Rename gl_save_CPPFLAGS to gl_saved_CPPFLAGS.
        * m4/lib-link.m4: Rename ac_save_CPPFLAGS to acl_save_CPPFLAGS.
        * m4/iconv.m4, m4/readline.m4: Rename am_save_CPPFLAGS to
        gl_saved_CPPFLAGS.
        * m4/gettext.m4: Rename gt_save_CPPFLAGS to gt_saved_CPPFLAGS.
        * m4/ansi-c++.m4: Rename gl_save_CXX to gl_saved_CXX.
        * m4/manywarnings-c++.m4: Rename gl_save_CXXFLAGS to gl_saved_CXXFLAGS.
        * m4/lib-link.m4: Rename acl_save_ifs to acl_saved_IFS.
        * m4/lib-prefix.m4: Rename acl_save_IFS to acl_saved_IFS.
        * m4/progtest.m4: Rename ac_save_IFS to gt_saved_IFS.
        * m4/lib-link.m4: Rename save_libdir to saved_libdir, acl_save_libdir to
        acl_saved_libdir.
        * m4/ld-version-script.m4: Rename save_LDFLAGS to saved_LDFLAGS.
        * m4/acl.m4, m4/getgroups.m4: Rename ac_save_LIBS to gl_saved_LIBS.
        * m4/lib-link.m4: Rename ac_save_LIBS to acl_saved_LIBS.
        * m4/getdomainname.m4, m4/gethostname.m4, m4/getloadavg.m4,
        m4/hostent.m4, m4/inet_ntop.m4, m4/inet_pton.m4,
        m4/pthread_mutex_timedlock.m4, m4/pthread_sigmask.m4,
        m4/pthread-spin.m4, m4/readutmp.m4, m4/selinux-selinux-h.m4,
        m4/servent.m4, m4/socketlib.m4, m4/termcap.m4, m4/terminfo.m4,
        m4/thread.m4: Rename gl_save_LIBS to gl_saved_LIBS.
        * m4/getaddrinfo.m4, m4/iconv.m4, m4/readline.m4: Rename am_save_LIBS to
        gl_saved_LIBS.
        * m4/gettext.m4, m4/intlmacosx.m4: Rename gt_save_LIBS to gt_saved_LIBS.
        * m4/libunistring.m4: Rename glus_save_LIBS to glus_saved_LIBS.
        * m4/nanosleep.m4: Rename nanosleep_save_libs to gl_saved_LIBS.
        * m4/lib-prefix.m4: Rename acl_save_prefix to acl_saved_prefix,
        acl_save_exec_prefix to acl_saved_exec_prefix.
        * m4/configmake.m4: Rename gl_save_<variable> to gl_saved_<variable>.
        * m4/terminfo.m4: Likewise.
        * m4/gettext.m4: Rename gt_save_<variable> to gt_saved_<variable>.
        * m4/javaexec.m4: Rename save_CLASSPATH to gt_saved_CLASSPATH.
        * m4/warnings.m4: Rename gl_save_compiler_FLAGS to
        gl_saved_compiler_FLAGS.
        * lib/pread.c, lib/pwrite.c, lib/read-file.c, lib/tempname.c: Rename
        save_errno to saved_errno.
        * lib/read-file.c: Rename save_alloc to saved_alloc.
        * lib/strptime.c: Rename save_wday to saved_wday, save_mday to
        saved_mday, save_mon to saved_mon.

0001-Improve-naming-of-local-variables.patch
Description: Text Data