Re: fix for source includes in gendoc.sh for future consideration

[Bruno Haible]

Hi Patrice,

> It may be strange to apply it now, before the Texinfo release, however.  I
> can re-propose it after the Texinfo release, you tell me.

It's unlikely that the --trace-includes features gets removed again before
the texinfo 7.2 release, right? Then it's OK to commit a patch like this
into Gnulib now.

But

  - The 'case' statement is misindented: should indent by 2, not 3 spaces.

  - What's the point of the 'eval'? Can't you get rid of it? And if not,
    then make it safer by writing
      cmd="\\$SETLANG \\$MAKEINFO \\$commonarg --trace-includes \"\\$base\""

  - Better indentation: Hiding the command name 'tar' in the middle of a line
    is not ideal, when this command spans multiple lines. Also, the GNU
    standards favour listing the operators at the beginning of a line, not
    at the end. I mean, change

    eval "$cmd" | tar -czhf "$abs_outdir/$PACKAGE.texi.tar.gz" \
      --verbatim-files-from -T- -- "$base" $pats \
      ${source_extra+"$source_extra"} &&
    ls -l "$abs_outdir/$PACKAGE.texi.tar.gz"

    to

    eval "$cmd" \
    | tar -czhf "$abs_outdir/$PACKAGE.texi.tar.gz" \
        --verbatim-files-from -T- -- "$base" $pats \
        ${source_extra+"$source_extra"} \
    && ls -l "$abs_outdir/$PACKAGE.texi.tar.gz"

Bruno