Re: gnulib-tool.py: Use case-sensitive sorting for files.

[Bruno Haible]

Collin Funk wrote:
> This patch fixes this issue.
> 
> I was a bit suspicious of this sorted() call previously, but left it
> because I had no proof it was incorrect.
> 
> diff --git a/pygnulib/GLImport.py b/pygnulib/GLImport.py
> index 294a8df979..0adfd8a73c 100644
> --- a/pygnulib/GLImport.py
> +++ b/pygnulib/GLImport.py
> @@ -942,7 +942,7 @@ AC_DEFUN([%s_FILE_LIST], [\n''' % macro_prefix
>          # Determine the final file lists.
>          main_filelist, tests_filelist = \
>              self.moduletable.filelist_separately(main_modules, tests_modules)
> -        filelist = sorted(set(main_filelist + tests_filelist), key=str.lower)
> +        filelist = sorted(set(main_filelist + tests_filelist))
>          if not filelist:
>              raise GLError(12, None)
> 
> This seems to match gnulib-tool.sh line 3562:
> 
>      files=`{ echo "$main_files"; echo "$testsrelated_files"; } | sed -e 
> "$sed_remove_empty_lines" | LC_ALL=C sort -u`

Thanks! Applied.

I would say that we don't need an additional unit test for this, since
it was a minor mistake only and we're not likely to regress on it in the
future.

Bruno