bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

gnulib-tool.py: Accept valid make syntax for escaped newlines.


From: Collin Funk
Subject: gnulib-tool.py: Accept valid make syntax for escaped newlines.
Date: Tue, 2 Apr 2024 04:14:42 -0700
User-agent: Mozilla Thunderbird

I noticed that in a few places where gnulib-tool.sh uses
'combine_lines', gnulib-tool.py uses 'remove_backslash_newline'.

These functions behave differently. Using this Makefile:

$ cat Makefile 

FILES = file1.c\
file2.c\
file3.c

all:
        @echo $(FILES)

$ make
file1.c file2.c file3.c

The 'combine_lines' functions adds spaces when replacing the backslash
newlines. The 'remove_backslash_newline' doesn't. In other words, we
would get this string returned in gnulib-tool.py:

file1.cfile2.cfile3.c

I don't think that our module files or Makefiles are ever written like
this. But since gnulib-tool.sh accepts it, and it is valid Make,
gnulib-tool.py should accept it too.

Collin

Attachment: 0001-gnulib-tool.py-Accept-valid-make-syntax-for-escaped-.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]