Re: gnulib-tool.py: Don't default to 'build-aux' for --auxdir.

[Bruno Haible]

Hi Collin,

> lines 7251-7274 in gnulib-tool.sh:
> 
>     # Analyze configure.ac.
>     guessed_auxdir="."
>     guessed_libtool=false
>     ...
>       /AC_CONFIG_AUX_DIR/ {
>         s,^.*AC_CONFIG_AUX_DIR([[ ]*\([^]"$`\\)]*\).*$,guessed_auxdir="\1",p
>       }
>     ...
>     if test -z "$auxdir"; then
>       auxdir="$guessed_auxdir"
>     fi
> 
> I think that this means if no --auxdir is passed to gnulib-tool, use
> whatever is found in 'AC_CONFIG_AUX_DIR' of configure.ac. If not found
> use the destination directory.

Yes, that's what it means.

> It seems that GLConfig.__getitem__(), used for indexing [1] would
> always return 'build-aux' when given the 'auxdir' key.

Not exactly. What this code did:

        if y in self.table:
            if y == "auxdir":
                if self.table['auxdir']:
                    return self.table['auxdir']
                return "build-aux"
            return self.table[y]

is to return 'build-aux' instead of returning ''.

> This seems correct to me since all tests still pass and in freedink:
> 
>     env GNULIB_TOOL_IMPL=sh+py gnulib-tool ./bootstrap
> 
> works correctly.

Thanks! Applied, with a corrected ChangeLog wording.

Bruno