bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: all-modules: Fix warnings in --version output.


From: Bruno Haible
Subject: Re: all-modules: Fix warnings in --version output.
Date: Fri, 05 Apr 2024 04:25:31 +0200

Hi Collin,

> Running this script:
> 
>     $ ./all-modules --version
>     ./all-modules: line 44: func_gnulib_dir: command not found
>     sed: can't read /ChangeLog: No such file or directory
>     ./all-modules: line 65: /build-aux/mdate-sh: No such file or directory
>     all-modules (GNU gnulib )
>     Copyright (C)  Free Software Foundation, Inc.
>     License GPLv3+: GNU GPL version 3 or later 
> <https://gnu.org/licenses/gpl.html>
>     This is free software: you are free to change and redistribute it.
>     There is NO WARRANTY, to the extent permitted by law.
> 
>     Written by Bruno Haible
> 
> The first patch copies the missing function from 'posix-modules'.

Thanks for this, but it is incomplete: func_gnulib_dir depends on a couple
of other functions, which need to be defined as well.

Also, it is useful to follow the function reordering in gnulib-tool.sh
from 2024-02-28. I'm therefore applying the two attached patches instead.

> The date output in both of those scripts is incorrect for me:
> 
>     posix-modules (GNU gnulib 2024-04-04 00:00:00) 0.1.7344-83a61
> 
> I remember we addressed this when I first started working on the
> Python version of gnulib-tool. There it caused an uncaught exception
> because of an out of bounds index, instead of an incorrect time 
> value. :)
> 
> The second patch just copies that change:

Thanks! Applied.

Bruno

Attachment: 0001-posix-modules-Sync-auxiliary-functions-from-gnulib-t.patch
Description: Text Data

Attachment: 0002-all-modules-Fix-errors-during-.-all-modules-version-.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]