Re: gnulib-tool.py: Remove a redundant function.

[Bruno Haible]

Hi Collin,

> But I think the idea of the patch is still
> correct. Since it doesn't make sense to accept a list and then only
> use it with one element lists.

Sure. This code structure comes from the fact that in the shell
implementation, the rewriting of file names is done through a 'sed' invocation,
and that is equally suited to a single file name or a list of file names.

> > Also, the last hunk makes use of yet another Python built-in function 'zip',
> > where list comprehension [ ... for ... in ... ] is more readable.
> 
> Maybe I am missing something, but I don't think there is a good way to
> use a list comprehension here without 'zip'. Since 'zip' is used to
> combine these two lists like so:

I'm talking about this piece of code:

        filetable = []
        for src in filelist:
            dest = self.rewrite_files([src])[-1]
            filetable.append(tuple([dest, src]))

which can be written as

        filetable = [ tuple([self.rewrite_filename(src), src])
                      for src in filelist ]

Bruno