Re: Refactoring rewrite_filename functions

[Bruno Haible]

Hi Collin,

> I'm thinking of making this function accept a single filename instead
> of a list

Makes sense, as previously discussed.

> and then moving it to GLConfig.

This does not make sense. GLConfig is meant to hold settings and configuration,
nothing more.

I see the home of this function more in GLFileSystem.py. Maybe in class
GLFileAssistant, maybe in a new class in that same file.

> Also, there is a similar section of code to this new function in
> main.py line 1313 under "mode == 'copy-file'", but it is missing the
> 'tests=lib/' replacement. Would there be a way to simplify that too?
> The use of 'tests=lib/' is escaping my mind at the moment...

'tests=lib/' should not occur in the scope of mode == 'copy-file'.
But this string is an indicator inside gnulib-tool; users of gnulib-tool
should not be allowed to pass it.

Bruno