[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnulib-tool.py: Fix pylint 'attribute-defined-outside-init' warnings
From: |
Bruno Haible |
Subject: |
Re: gnulib-tool.py: Fix pylint 'attribute-defined-outside-init' warnings. |
Date: |
Fri, 19 Apr 2024 19:03:35 +0200 |
Collin Funk wrote:
> I submitted a feature request here since I think a configuration
> option would probably be the best fix:
>
> https://github.com/pylint-dev/pylint/issues/9555
Thank you!
> When I say obvious in GLModule we have (comments are added):
>
> # Cache for the getter functions.
> self.cache = dict()
> # Raw content of description file.
> self.content = ''
> self.filesystem = GLFileSystem(self.config)
> self.modulesystem = GLModuleSystem(self.config)
>
> It is very clear that the cache and content are meant for internal
> use. The filesystem and modulesystem are less clear to me. I think
> they *could* be used from the outside, but should they be? Those will
> take more consideration.
Yes. There are actually two questions to ask for each property:
- Is it currently used from outside the class?
- Would it make sense to use it from outside the class, given the
existing methods?
Bruno