[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnulib-tool.py: Simplify data structures for dependencies.
From: |
Collin Funk |
Subject: |
Re: gnulib-tool.py: Simplify data structures for dependencies. |
Date: |
Fri, 19 Apr 2024 17:13:53 -0700 |
User-agent: |
Mozilla Thunderbird |
On 4/19/24 2:37 PM, Bruno Haible wrote:
> You're right. Maybe Dmitry wanted to have the full data structure
> available somewhere; but since the 'conditionals' and 'unconditionals'
> tables contain the same info in a different way, it's redundant.
>
> I would leave it in, for possible future uses, since it does not consume
> much memory. Just add a comment that it's currently unused, and is kept
> for possible future use.
Sure, that makes sense. It seems useful which is why I thought I was
missing something. I'll add a comment next time I make changes around
there.
> 4. inst.getName(): This is similar to inst.get_name() but follows the
> convention of using CamelCase for method names, which is common in
> some coding styles. However, in Python, the convention is typically
> to use lowercase letters and underscores for method names (get_name()).
Ah, the prior knowledge summarization engine is an advocate of PEP 8.
I've been meaning to get around to the "module.get_name() vs.
module.getName()" naming convention issue because we have a mix of
both at the moment. It just hasn't bothered me enough yet so I've
focused on other things. :)
Collin