bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

gnulib-tool.sh: Match sorting of gnulib-tool.py in output.


From: Collin Funk
Subject: gnulib-tool.sh: Match sorting of gnulib-tool.py in output.
Date: Sat, 27 Apr 2024 14:14:52 -0700
User-agent: Mozilla Thunderbird

Hi Bruno,

When looking at your bug report I noticed a few lines of the diff are
just different orderings.

Running:

    GNULIB_TOOL_IMPL=sh+py ./gnulib-tool --create-megatestdir --dir=testdir2 
--single-configure sys_types stdio

We see in the diff:

diff -ru testdir2/Makefile.am testdir2-glpy85706/Makefile.am
--- testdir2/Makefile.am        2024-04-27 13:53:51.443692945 -0700
+++ testdir2-glpy85706/Makefile.am      2024-04-27 13:53:33.063660555 -0700
@@ -2,6 +2,6 @@
 
 AUTOMAKE_OPTIONS = 1.14 foreign
 
-SUBDIRS = sys_types stdio ALL
+SUBDIRS = stdio sys_types ALL

This can also be seen in configure.ac and the generated configure
script. The behavior of gnulib-tool.py is to sort the modules and
gnulib-tool.sh uses them as passed.

I feel like the best solution here is just to sort the modules in
gnulib-tool.sh. Since gnulib-tool.py turns the strings into a set of
GLModules and then sorts them.

Can I apply the attached patch? Asking since I feel less comfortable
making changes outside of pygnulib/* and I'm not sure if/how to apply
them to stable branches.

Collin

Attachment: 0001-gnulib-tool.sh-Match-sorting-of-gnulib-tool.py-in-ou.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]