[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output.
From: |
Bruno Haible |
Subject: |
Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output. |
Date: |
Sun, 28 Apr 2024 00:22:32 +0200 |
Hi Collin,
> I've pushed the attached patch
Thanks. There's a nit, though: These lines do not remove duplicates.
module_set = set(modules)
modules = [ module
for module in modules
if module in module_set ]
See:
>>> modules = ['a', 'b', 'a', 'c', 'b']
>>> module_set = set(modules)
>>> modules = [ module for module in modules if module in module_set ]
>>> modules
['a', 'b', 'a', 'c', 'b']
> since it allows me to run this and pass:
>
> GNULIB_TOOL_IMPL=sh+py ./gnulib-tool --create-megatestdir --dir=testdir2
> --single-configure sys_types stdio
>
> Can you double check on your machine?
I confirm, it passes for me as well now.
But I'm confused: I thought part of the problem was that a libtests was being
generated. Putting the modules in a different order makes the libtests
disappear?? What is going on?
Bruno
- gnulib-tool.sh: Match sorting of gnulib-tool.py in output., Collin Funk, 2024/04/27
- Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output., Bruno Haible, 2024/04/27
- Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output., Collin Funk, 2024/04/27
- Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output.,
Bruno Haible <=
- Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output., Collin Funk, 2024/04/27
- Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output., Bruno Haible, 2024/04/27
- Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output., Collin Funk, 2024/04/27
- Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output., Collin Funk, 2024/04/27
- Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output., Bruno Haible, 2024/04/28
- Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output., Collin Funk, 2024/04/28