Re: gnulib-tool.sh: Match sorting of gnulib-tool.py in output.

[Collin Funk]

Hi Bruno,

On 4/27/24 5:29 PM, Collin Funk wrote:
> I'm thinking that this is due to GLTestDir creating a GLEmiter in
> __init__() like this:
[...]
> The 'libtests' value read from the config in self.emitter is
> incorrect.

This patch seems to support what I was saying here.

diff --git a/pygnulib/GLTestDir.py b/pygnulib/GLTestDir.py
index 002eb30267..11b067e085 100644
--- a/pygnulib/GLTestDir.py
+++ b/pygnulib/GLTestDir.py
@@ -244,8 +244,7 @@ def execute(self) -> None:
                     if file.startswith('lib/'):
                         libtests = True
                         break
-            if libtests:
-                self.config.setLibtests(True)
+            self.emitter.config.setLibtests(libtests)
 
         if single_configure:
             # Add the dummy module to the main module list if needed.

Though, the correct way to fix this would be making instance variables
local when they are only used in one function.

I was having a look at doing that when I submitted this patch:

    https://lists.gnu.org/archive/html/bug-gnulib/2024-04/msg00444.html

Since I also noticed some in GLImport. Since we don't want to
introduce any major changes for a bit after your announcement, should
we just leave this for a few days?

Thanks.

Collin