[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Pacify -Wmissing-variable-declarations in unit tests.
From: |
Collin Funk |
Subject: |
Re: Pacify -Wmissing-variable-declarations in unit tests. |
Date: |
Sun, 28 Apr 2024 17:58:43 -0700 |
User-agent: |
Mozilla Thunderbird |
Hi Paul,
On 4/28/24 4:27 PM, Paul Eggert wrote:
> For test cases this is more a judgment call, but I prefer doing either
> the above or adjusting the warning flags, to ignoring warnings, as the
> other warnings can be useful at time.
Yeah, I could see these warnings making it hard to see ones that
actually matter. Lets see what Bruno thinks.
The patch in the original email should contain all of the variables
that trigger it. If we decide to follow the coding style you mentioned
I can make all the obvious ones static, i.e. checking for variables
being defined in gnulib headers.
Collin