[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Tue, 05 Nov 2002 11:03:12 +0100
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2b) Gecko/20021016
Adam Fedor wrote:
Caba Conti wrote:
(Using a version from CVS of october 26th)
In the file "core/gui/Source/NSWorkspace.m"
in the method "_workspaceApplication":
The hardcoded default value for the workspace application is:
Is this a typo? ... shouldn't this be @"GWorkspace"?
I fixed this.
Excuse me for budding in, but I'm not sure whether the current setup is
I think either GWorkspace should be part of the GNUstep "package" (and
therefore also in the main CVS) or its one of (theoretically mutliple)
workplace applications, that can set (and maybe should be responsible
for setting) the GSWorkspaceApplication default, if it hasn't been set.
The user should be able to explicitly reset it in the prefernces of
GWorkspace (or Preferences.app for all I care).
And in this case, I don't think there should be any default value at
all, and the methods needing this should raise with the apropriate
message. Yet one can argue that -peformFileOperation:...
-selectFile:... are part of the API and they are to be implemented by
using a workspace app. Then I would go back to making GWorkspace part of
the core gui package.
I'm not too worried about this so I won't respond to any possible flames
this may induce, but I think the current setup is bit ambiguous, and I
thought I might voice it.
But anyway please also update the documentation also to reflect your change: