[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

NSPopUpButton and NSMenuView patches and questions

From: Serg Stoyan
Subject: NSPopUpButton and NSMenuView patches and questions
Date: Sun, 19 Jan 2003 22:53:29 +0200


I've made two patches that fixes some issues with NSPopUpButton and 
NSMenuView. These issues are following:

- when disabled item selected, action doesn't perform but this item remains   
selected. Fixed to leave selection unchanged;
- when item is selected by key equivalent, action performs but no selection

- do not perform [targetMenuView setHighlightedItemIndex: -1] if menu owned   
by NSPopUpButton. Fixes problem with items highlighting/unhighlighting.
- visual feedback in application menu fixed. [NSThread sleepUntilDate:] 
  changed to [[NSRunLoop currentRunLoop] runUntilDate:] and placed before
  [_menu performActionForItemAtIndex: index].

And some questions left. When last item in NSPopUpButton selected all key 
equivalents disappear from items (but still works). Selecting any other
item returns them back.

Another question is: when item has key equivalent and selected (displaying 
NSPopUpButton image on the right side (i don't know how it named) after 
mouse button up). In OpenStep it isn't. Is it responsibility of application
or AppKit to remove key equivalent while item stays visible?

Serg Stoyan

Attachment: NSMenuView.m.patch
Description: Binary data

Attachment: NSPopUpButton.m.patch
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]