[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch/base](HEAD & branch) NSDecimalFromComponents compatibility fu

From: David Ayers
Subject: Re: [Patch/base](HEAD & branch) NSDecimalFromComponents compatibility function
Date: Fri, 12 Sep 2003 11:12:35 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4b) Gecko/20030507

Adam Fedor wrote:

GSCompatibility.h is for compiling base-add (basically internal routines and defines that need to be seen internally).

NSDecimalFromComponents should probably go in GSCategories.h (maybe there is other stuff in GSCompatibility.h that should go there, I haven't really looked at that much).

Well at first sight, I can't find any declaration that I would consider truely -bassadd internal. Both GDL2 and GSWeb
- use the logging macros
- use some the declared categories (some of which are also declared in GSCategories already)
- could be using some of the NSGNUstepStringEncoding values.

To me it seems the entire headers should be either public or have it's contents moved to GSCategories.h

I'm not sure how we should fair for the release. On the one hand, I don't want to shake it up at this stage, on the other hand, it may turn out that we my want to change the public headers again :-/ This simpelest approach in my view is to move the contents of GSCompatibility.h to GSCategories.h, remove GSCompatibility.h and addapt the internal references to it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]