bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #4706] gopen should use absolute path of filename


From: nobody
Subject: [bug #4706] gopen should use absolute path of filename
Date: Fri, 24 Oct 2003 05:29:58 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20031010 Debian/1.4-6

=================== BUG #4706: LATEST MODIFICATIONS ==================
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4706&group_id=99

Changes by: Richard Frith-Macdonald <address@hidden>
Date: Fri 10/24/03 at 09:29 (GMT)

------------------ Additional Follow-up Comments ----------------------------
Thanks ... I've fixed it in cvs.



As regards the use of '/' as a path separator in strings, my understanding is 
that this is OK as it's the separator used internally by 
GNUstep/OpenStep/MacOS-X.  Only when we actually want to use a path in a antive 
systemcall etc do we translate it from an NSString to a C-string using 
NSFileManagers method fileSystemRepresentationWithPath:, and it is that method 
which converts from the internal path separator ('/') to the systems native 
separator.



That being said, I think it's good practice to append path components using the 
appropriate method.



=================== BUG #4706: FULL BUG SNAPSHOT ===================


Submitted by: stefanu                 Project: GNUstep                      
Submitted on: Sun 08/10/03 at 21:46
Category:  Gui/AppKit                 Severity:  3                          
Bug Group:  Bug                       Resolution:  None                     
Assigned to:  gcasa                   Status:  Open                         

Summary:  gopen should use absolute path of filename

Original Submission:  1. openapp Ink.app in ~

2. have some.rtf in ~

3. go to /tmp and have different some.rtf in /tmp

4. run: 'gopen some.tmp' in /tmp -> ~/some.rtf is opened

5. have other.rtf in /tmp and run 'gopen other.rtf' -> Ink will complain that 
the file does not exists



Patch is attached.



p.s.: by looking at ths bug i've seen some string appendings for paths using 
'/' instead of using stringByAppendingPathComponent: in NSWorkspace.m. i think 
that should be fixed to prevent future failures on mswindows or other os.

Follow-up Comments
*******************

-------------------------------------------------------
Date: Fri 10/24/03 at 09:29         By: CaS
Thanks ... I've fixed it in cvs.



As regards the use of '/' as a path separator in strings, my understanding is 
that this is OK as it's the separator used internally by 
GNUstep/OpenStep/MacOS-X.  Only when we actually want to use a path in a antive 
systemcall etc do we translate it from an NSString to a C-string using 
NSFileManagers method fileSystemRepresentationWithPath:, and it is that method 
which converts from the internal path separator ('/') to the systems native 
separator.



That being said, I think it's good practice to append path components using the 
appropriate method.


CC list is empty


File Attachments
****************

-------------------------------------------------------
Date: Sun 08/10/03 at 21:46  Name: gopen.m.patch  Size: 0KB   By: stefanu

http://savannah.gnu.org/bugs/download.php?group_id=99&amp;bug_id=4706&amp;bug_file_id=588


For detailed info, follow this link:
http://savannah.gnu.org/bugs/?func=detailbug&bug_id=4706&group_id=99

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]