bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] NSCalendar date patch


From: Wim Oudshoorn
Subject: Re: [PATCH] NSCalendar date patch
Date: Wed, 25 Feb 2004 15:30:35 +0100
User-agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3.50 (darwin)

Richard Frith-Macdonald <address@hidden> writes:

> On 25 Feb 2004, at 13:22, Wim Oudshoorn wrote:
>> Solution
>> --------
>> The following patch will solve all these problems EXCEPT
>> the first.  It will introduce a strcpy of the format string
>> which is in most cases not necessary, but I do not
>> think this is a critical problem.
>> Also the %c %X %x conversion are not really efficient.
>> And it bothers me a little that the buffer overrun is
>> still there, but getting rid of that requires siginificantly
>> more work.
>
> Frankly, IMO, the code needs a complete rewrite.
>
> 1. The potential (though unlikey) overflow should be fixed.
> 2. the method should support unicode

Yes, I agree.  But this was quicker :-).

> So, while I don't object to the patch as such, I'd like it much
> better if it created a mutable data object and appended unichars to
> it then converted the result to a string when done.

I might do this, but in the meantime I would like to commit
this as a temporary solution.  
For me the NSThread thing has higher priority.

Wim Oudshoorn.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]