bug-gnustep
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bugs #10214] Patch for GSXML under amd64


From: Richard Frith-Macdonald
Subject: [bugs #10214] Patch for GSXML under amd64
Date: Mon, 01 Nov 2004 03:17:30 -0500
User-agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en) AppleWebKit/125.5 (KHTML, like Gecko) Safari/125.9

This mail is an automated notification from the bugs tracker
 of the project: GNUstep.

/**************************************************************************/
[bugs #10214] Latest Modifications:

Changes by: 
                Richard Frith-Macdonald <address@hidden>
'Date: 
                Mon 11/01/2004 at 08:10 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
Thanks for the patch.
Rather than change the public API with this patch, I have modified the usage of 
NSMapTable to (I hope) work properly on a 64bit processor where sizeof(int) != 
sizeof(void*)
Please let me know if there are any problems with this.






/**************************************************************************/
[bugs #10214] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=10214>
Project: GNUstep
Submitted by: Pete French
On: Sun 08/29/2004 at 18:25

Category:  Base/Foundation
Severity:  5 - Average
Item Group:  Change Request
Resolution:  Fixed
Privacy:  Public
Assigned to:  None
Status:  Closed


Summary:  Patch for GSXML under amd64

Original Submission:  The attached patch changes the 'type' from an int
to a long throughout. This is because it is stored in
a void* in the NSMapTable which is longer than an int
on amd64. This may not be a problem when storing, but
could be on retrieval as a void** was being passed with
the address of an int. It also changes the way the hash is
calculated slightly to remove a waning and retain as
much uniqueness as possible.

As the sizeof an int and a long are the same on all
other architectures then this patch does not affect
operation on non amd64 systems in any way. It passes
the guile GSXML test on those systems.

Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 11/01/2004 at 08:10       By: Richard Frith-Macdonald <CaS>
Thanks for the patch.
Rather than change the public API with this patch, I have modified the usage of 
NSMapTable to (I hope) work properly on a 64bit processor where sizeof(int) != 
sizeof(void*)
Please let me know if there are any problems with this.






File Attachments
-------------------

-------------------------------------------------------
Date: Sun 08/29/2004 at 18:25  Name: gsxml.diff  Size: 9.27KB   By: minusbat
Patchfile for GSXML.m and GSXML.h
http://savannah.gnu.org/bugs/download.php?item_id=10214&amp;item_file_id=1625






For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=10214>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/







reply via email to

[Prev in Thread] Current Thread [Next in Thread]