[patch #4230] base: exception enhancements

[Jeremy Bettis]

URL:
  <http://savannah.gnu.org/patch/?func=detailitem&item_id=4230>

                 Summary: base: exception enhancements
                 Project: GNUstep
            Submitted by: jeremybettis
            Submitted on: Mon 07/25/2005 at 15:32
                Category: Foundation
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open

    _______________________________________________________

Details:

Ok, this might be contraversial, but here goes:

I added a few debugging checks in the exception handler code, all #ifdef
DEBUG, and most of them #ifdef WIN32 as well.  It checks for bad pointers on
windows.

I noticed (when trying to debug some bad pointers in exception handlers in my
code) that the handler struct that needs to be removed is passed to
_NSRemoveHandler.

Therefore, instead of starting at thread->_exception_handler and working your
way down through the frames, why not just use the passed in struct.  This way,
if some bonehead called return in an NS_DURING block, perhaps you can still
remove the exception handler without accessing memory that is on a freed
section of the stack.

These changes have made my exception handler problems easier to find and fix,
and perhaps it will be helpful for others.






    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?func=detailitem&item_id=4230>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/