[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #15112] NSToolbar has wrong behaviour in IconOnly and LabelOnly mod

From: Wolfgang Sourdeau
Subject: [bug #15112] NSToolbar has wrong behaviour in IconOnly and LabelOnly modes (patch attached)
Date: Wed, 30 Nov 2005 16:49:45 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.7.12) Gecko/20050922 Firefox/1.0.7 (Debian package 1.0.7-1)


                 Summary: NSToolbar has wrong behaviour in IconOnly and
LabelOnly modes (patch attached)
                 Project: GNUstep
            Submitted by: wolfgang
            Submitted on: mer 30.11.2005 à 16:49
                Category: Gui/AppKit
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open



This patch was already posted to bug-gnustep. Reposted here for correct bug
management practice.

This patch fixes the following problems:

- the generated menus for toolbars were given entries for unlabelled
  standard items: separators, spaces and flexible spaces

- whenever the cell type would change, the _contents ivar would be set
  to @"title". I changed it to do that only when _contents is unset.
  Besides, I was not sure if setting @"title" was very useful but I let
  it that way in case there was a reason. This fixes the case where
  NSToolbar with displayMode set to LabelOnly would redefine the item
  labels to "title".

- in GSToolbarButton's layout method:
  the size for the cell of labelled toolbar items would take the label
  size into account even when the toolbar display mode was set to
- in NSToolbarItem's initWithItemIdentifier: method:
  a double negation in the test on itemIdentifier was causing the item
  to never be reinited to a GSToolbarSeparatorItem.


File Attachments:

Date: mer 30.11.2005 à 16:49  Name: toolbarfixes.diff  Size: 6,19Ko   By:
fixes for the bugs mentioned above


Reply to this item at:


  Message posté via/par Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]