[bug #15112] NSToolbar has wrong behaviour in IconOnly and LabelOnly modes (patch attached)

[Quentin Mathé]

Follow-up Comment #5, bug #15112 (project gnustep):

For the first part of the bug report about GSToolbarView, I have to say I'm
unable to reproduce this wrong behaviour. However it is possible I haven't
well understood your bug description or I need more informations to reproduce
it...

In current implementation, only items which return non nil value for both
-menuFormRepresentation and -_defaultMenuFormRepresentation are added to the
menu of clipped items. Finally -menuFormRepresentation returns nil by default
for any items and -_defaultMenuFormRepresentation is overriden by
NSToolbarItem subclasses like GSToolbarSeparatorItem, GSToolbarSpaceItem and
GSToolbarFlexibleSpaceItem to return nil. That's why special items you
mention shouldn't be present in the clipped items menu (and they aren't in my
tests).

I put some NSLog in -returnMenu method, here is what I get for example:
item <NSToolbarItem: 8355dd8>
menuItem <NSMenuItem: 82dde90>
item <GSToolbarSeparatorItem: 835a308>
item <GSToolbarCustomizeToolbarItem: 835a5f0>
menuItem <NSMenuItem: 822f020>
item <GSToolbarFlexibleSpaceItem: 8370330>

Menu items are created only for <NSToolbarItem: 8355dd8> and
<GSToolbarCustomizeToolbarItem: 835a5f0> but not the others.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=15112>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/