[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #28590] Cairo backend displays wrong colors on X server with a diff

From: Fred Kiefer
Subject: [bug #28590] Cairo backend displays wrong colors on X server with a different endianness
Date: Wed, 20 Jan 2010 14:47:38 +0000
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; de; rv: Gecko/20091201 SUSE/3.5.6-1.1.1 Firefox/3.5.6

Follow-up Comment #8, bug #28590 (project gnustep):

Looks like I didn't express myself clear enough. Sorry for that.

What I tried to say was that we should put any patch into the file
XWindowBuffer.m. And we only need to change any code in the case where we
don't use shared memory (this is for some reason broken on modern X Servers
and I don't have a clue).
This means we need to set the properties of the XImage we create in line 390
of that file. And a line like

wi->ximage->byte_order = ImageByteOrder(wi->display);

Should do the trick for cairo. This is very similar to your patch, just at a
different place. If your change works this one should work just as well.

Now we have to test how this affects the xlib and the art backend and I am
not able to test this. If this change breaks any of these backends we need to
rework it, by passing in the byte order via the DI structure. Lets discuss
this case, when it is actually needed.

Does this explanation make any more sense to you than the last one?


Reply to this item at:


  Nachricht geschickt von/durch Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]