[bug #29627] There is the logical error at [EODatabaseContext prepareForSaveWithCoordinator:editingContext:]

[Sergey Golovin]

URL:
  <http://savannah.gnu.org/bugs/?29627>

                 Summary: There is the logical error at [EODatabaseContext
prepareForSaveWithCoordinator:editingContext:]
                 Project: GNUstep
            Submitted by: svg
            Submitted on: Срд 21 Апр 2010 19:42:06
                Category: gdl2
                Severity: 3 - Normal
              Item Group: Bug
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

[EODatabaseContext prepareForSaveWithCoordinator:editingContext:] makes
primary keys for objects. Making is implemented by two rounds. The objects
which are leaved without primary keys after first round have a chance to get
theirs during second one. The array noPKobjects should be filled by such
objects during first round. Now the problem can be seen in the following code
snippet (not important lines are missed):
------------------------------------------------------------
for(round=0;round<2;round++)
 {
   <...>
   if (round==1 && [noPKObjects count]==0)
        break;
   else
     {
        NSArray* array=nil;
        if (round==0)
            array=insertedObjects;
        else
          { 
            array=noPKObjects;
            <...>
          }
        count = [array count];
        if (count>0)
          {
            IMP oaiIMP=[array methodForSelector: @selector(objectAtIndex:)];

            for (i = 0; i < count; i++)
              { 
                 id object = GDL2_ObjectAtIndexWithImp(array,oaiIMP,i);
                 <...>
                 NSDictionary *objectPK;
                 objectPK = [self _primaryKeyForObject: object
raiseException: round>0];
                 <...>
                 if (objectPK)
                   {
                      <...>
                      if (round>0)
                        {
                           [noPKObjects removeObjectAtIndex:i];
                           i--;
                        };
                   }
                 else if (round>0) // the problem is here because
                                   // it only happens during 
                                   // the second phase when it
                                   // makes no sense
                   {
                     if (!noPKObjects)
                       noPKObjects=(NSMutableArray*)[NSMutableArray array];
                     [noPKObjects addObject:object];
                   }
                 
              }
     }

 }
------------------------------------------------------------

"else if (round>0)" should be replaced by "else if (round==0)" as the patch
does.





    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Срд 21 Апр 2010 19:42:06  Name: gdl2_EOAccess_2rounds.patch 
Size: 558B   By: svg

<http://savannah.gnu.org/bugs/download.php?file_id=20293>

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?29627>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/