[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #33741] GSGhostscriptImageRep uses hardcoded path /usr/bin/gs

From: Wolfgang Lux
Subject: [bug #33741] GSGhostscriptImageRep uses hardcoded path /usr/bin/gs
Date: Mon, 11 Jul 2011 10:09:49 +0000
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_8; en-US) AppleWebKit/531.21.8+(KHTML, like Gecko, Safari/528.16) Version/5.10.3 OmniWeb/622.14.0

Follow-up Comment #2, bug #33741 (project gnustep):

It works for me now, but looking at your code I'm not totally happy with it.

In particular, you now catch exceptions thrown by NSTask, but your handlers
are empty. This is BAD (even worse than not catching the exception at all)!
The minimum here is to log the exception, so users have at least a chance to
find a cause if a postscript is not displayed as expected. This might happen,
e.g., if a user has set the GSGhostscriptExecutablePath default manually, but
mistyped the path.

In the meantime, I was thinking about adding a configure time check to
determine the default path for gs, but autoconf (incorrectly) complains about
a possibly undefined AC_DEFINE macro at line 122. At the end, it turns out
that the real problem is the ImageMagick test you added in r33399. This uses
the PKG_CHECK_MODULES macro, which is not defined. I'm wondering how you
managed to update configure yourself.


Reply to this item at:


  Nachricht geschickt von/durch Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]