[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #60952] NSTimeZone fail to deal with tzfile v2+

From: Richard Frith-Macdonald
Subject: [bug #60952] NSTimeZone fail to deal with tzfile v2+
Date: Thu, 22 Jul 2021 05:51:41 -0400 (EDT)
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36

Update of bug #60952 (project gnustep):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => In Test                


Follow-up Comment #1:

Thanks very much for bringing that issue to my attention and providing a patch
to fix the problem.

I couldn't use your patch directly (a few bugs and a lack of copyright
assignment to the FSF), but have updated NSTimeZone on the lines you suggest.
I agree with the idea of always holding transitions in 64bit form, and it
won't break anything.

The significant bugs I spotted were a failure to update the variable 'when' in
the chop() function to be 64bit (which would make transition lookups fail for
dates that won't fit in 32 bits) and allocation of memory for the internal
memory using trans_size (32bits on v1) but then unconditionally treating that
memory as if it contained 64bit values.  Neither would have shown up if you
only tested using v2+ zone info and didn't try looking up transitions for
times after the year 2038.
The new code is now in the git repository;  please give it a try and update
this issue to let me know how you got on with it.

Thanks again for pointing this bug out.


Reply to this item at:


  Message sent via Savannah

reply via email to

[Prev in Thread] Current Thread [Next in Thread]