[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-gnuzilla] Rust issues

From: David Michael
Subject: [Bug-gnuzilla] Rust issues
Date: Sat, 30 Dec 2017 18:27:25 -0500


With Rust enabled, the IceCat build fails when Cargo verifies the
vendored crates' files' SHA-256 sums due to the s/Firefox/IceCat/g run
on the source.  Specifically, this can be fixed with:

sed -i -e s/IceCat/Firefox/g third_party/rust/idna/src/lib.rs

That command restores the original file's text so the SHA-256 tests
pass again.  (It only modifies a comment.)

Is there a preference on how this should be addressed for the future?
I suppose some options are to:

- Skip modifying vendored crates (which could be bad as more of
Firefox is rewritten in Rust)
- Overwrite .cargo-checksum.json files with an empty file list to skip
- Parse and edit the JSON files to test the SHA-256 values of modified files



It also needs something like adding "build = false" to
media/libstagefright/binding/mp4parse_capi/Cargo.toml as in upstream
bug #1338655 to work with current Cargo.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]