[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug-gperf] Re: [PATCH] Use always_inline attribute with gcc
From: |
Lucas De Marchi |
Subject: |
[bug-gperf] Re: [PATCH] Use always_inline attribute with gcc |
Date: |
Wed, 19 May 2010 09:58:47 -0300 |
On Wed, May 19, 2010 at 5:59 AM, Bruno Haible <address@hidden> wrote:
> I will certainly not apply a patch like this.
> 1) You have not provided an explanation and analysis of the problem that
> WebKit is facing. In <https://bugs.webkit.org/show_bug.cgi?id=29244>
> 12 persons participated in the discussion, and no one analyzed the
> problems. Your team needs to look at "nm" results, GCC versions,
> gcc command lines etc. more closely, read the GCC manual, and not
> just try this and that blindly without understanding the problem.
Sorry if it sounded like that, but I was not blindly testing this and
that. In fact I was playing the "nm game" and was able to fix most of
the problems. Since it started to become a little difficult for the
findValue symbol, I've stepped back and thought always inlining could
be a desired behavior, or at least have an option in gperf to tell
that I want it inlined or not.
> 2) If you have a problem that you mean to fix with __always_inline__,
> it is quite likely that your code will break with other compilers
> than GCC, which don't have __always_inline__. The only reasonable
> uses of __always_inline__ that I know of are
> - with inline asms,
> - when you play tricks with alloca,
> - when you write low-latency device drivers.
> 3) __always_inline__ hampers debuggability. When line numbers are not
> correct even with -O0 -g, people will swear.
ok.
Thanks.
Lucas De Marchi