[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [bug-grep] [patch] getting '--devices=skip' to work

From: Elliott Hughes
Subject: Re: [bug-grep] [patch] getting '--devices=skip' to work
Date: Fri, 19 Nov 2004 09:55:00 -0800

the trouble with checking-before-doing is that things can change in between. in this case, though, i agree that it looks like the better choice.


On Nov 18, 2004, at 23:36, Stepan Kasal wrote:

Hello Tim,

     while ((desc = open (file, O_RDONLY | O_NONBLOCK)) < 0
             && errno == EINTR)

my intuition was that it's safer to find out that we don't want to grep
the file before we try to open it.

Stop the bus!  There is a kernel change to do with opening normal
files with O_NONBLOCK having unexpected consequences.  It's best

Together with this comment from Tim, O_NONBLOCK is out of question.
But I'll probably check in Benno's patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]