Re: [bug-grep] grep patch proposal (-p, --position new option)

[Stepan Kasal]

Hi,

On Tue, Dec 14, 2004 at 07:53:01PM +0100, Claudio Fontana wrote:
> three trivial cosmetic issues:
> 
> - at line 527, local variable ilim is never used.
>           char *ilim = ibeg + (lim - beg);

that code (combination of -i with -o or --color) has worse problems.
I guess this will be gone when we deal with it.

> - spacing after if is sometimes incoherent. Mostly
> it's if (condition), however sometimes it's
> if(condition);
> 
> - likewise, mostly it's a - b, however sometimes it's
> a-b.

The forms with spaces are correct.

> I don't know if you're sensible to these things, so I
> just tell you.

Well, we are sensible to them.  However, we don't want to fix them
now, as there are many patches in the queue and such these detail
changes might be annoying sometimes.

When we get close to a release, I'd be glad to accept a patch
fixing these issues.

Thank you,
        Stepan