[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: restructure patch for review [bug-grep]

From: Charles Levert
Subject: Re: restructure patch for review [bug-grep]
Date: Mon, 7 Mar 2005 13:50:36 -0500
User-agent: Mutt/1.4.1i

* On Monday 2005-03-07 at 19:07:12 +0100, Claudio Fontana wrote:
> > 
> >   -- you also put them in your "struct
> >      grepopt" o variable and src/grep.c does
> >      the copying/adaptation from there to a
> >      "struct match_spec" variable.

> I agree to the second. Just a thought: instead of
> handcrafting the struct in grep.c directly, we could
> call an initialization function you expose, something
> like init_search(params); params are exactly (or built
> from) the options I keep in o. Just for the eye.

If a -p option similar to that of diff is ever
implemented (actually, I've had mine running for
weeks now, but based off an older RH version),
two struct variables would eventually need to be
constructed stlighly differently.  Plus, there
are place in src/grep.c where some of their
fields might be directly accessed.  So we'll
see what "params" should be.

> > Maybe I should also rename "match_spec" to
> > "search_spec" to correspond to the file name
> > before even publishing a first version.
> Seems nicer.

Yes, but both abbreviated forms leave to be
desired for different reasons:  ss and ms.
Nan, too much attention to details!

> > In addition to our respective work, the current
> > Red Hat performance-enhancing patches seem to
> > be non-trivial as well.
> Ah, why are those patches been kept separate from
> those in savannah?

They could each have their own Savannah patch
item, maybe just to alert any peruser of their


> Where can I get a comprensive list of those, and how
> are they related to patches in savannah?

They are under
as you already pointed to them in another message.

I guess that
is of particular interest.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]